Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.76.x - terminal ctrl-click code-line lookup regexp fails #176756

Closed
fenchu opened this issue Mar 10, 2023 · 1 comment · Fixed by #177084
Closed

v1.76.x - terminal ctrl-click code-line lookup regexp fails #176756

fenchu opened this issue Mar 10, 2023 · 1 comment · Fixed by #177084
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone
March 2023

Comments

@fenchu
Copy link

fenchu commented Mar 10, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.76.1
  • OS Version: windows 11

This worked before the 1.76.0 upgrade, I've also tested starting with code --disable-extensions

Steps to Reproduce:

  1. get output in terminal like:
    20230310122934.069|ERROR|C:\dist\work\multitenant-fullstack-test\tools\scim.py:495|user with username:15918896373 not found

  2. .ctrl+click and it fails miserably because the regex to fetch the url seem to be corrupt:
    it matches 'C:\dist\work\multitenant-fullstack-test\tools\scim.py:495|user'
    vscode-linelookup-regexp-fails

This works:
20230310124108.071|INFO|C:\dist\work\multitenant-fullstack-test\tests\test_03_scim_username.py:40|user from mock:{
vscode-linelookup-regexp-works
@meganrogge meganrogge assigned Tyriar and unassigned meganrogge Mar 10, 2023
@Tyriar
Copy link
Member

Tyriar commented Mar 14, 2023

This actually works fine for me when there's no line number:

image

Tyriar added a commit that referenced this issue Mar 14, 2023
@Tyriar
Exclude pipe char from suffix link paths
cc14fac 
Fixes #176756
@Tyriar Tyriar mentioned this issue Mar 14, 2023
Merged
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 14, 2023
@Tyriar Tyriar added this to the March 2023 milestone Mar 14, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 14, 2023
@meganrogge meganrogge added the verified Verification succeeded label Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Handle pipe char better in terminal links microsoft/vscode
4 participants
@Tyriar @fenchu @meganrogge @VSCodeTriageBot