Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onEnterRules add prefix on newline inside Javadoc #176800

Merged
merged 1 commit into from Mar 15, 2023

Conversation

mickaelistria
Copy link
Contributor

Add some onEnterRules to Java language configuration to add the usual prefix (*) when inserting a new line in Javadoc.
Those were actually copied from typescript language configuration which shares the same syntax for comments.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I just have a few comments!

extensions/java/language-configuration.json Show resolved Hide resolved
extensions/java/language-configuration.json Outdated Show resolved Hide resolved
Add some onEnterRules to Java language configuration to add the usual
prefix (` * `)
when inserting a new line in Javadoc.
Those were actually copied from typescript language configuration which
shares the
same syntax for comments.
@mickaelistria
Copy link
Contributor Author

@alexr00 thanks, newer version of this PR should cover your comments.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@alexr00 alexr00 added this to the March 2023 milestone Mar 14, 2023
@alexr00 alexr00 merged commit 4566ce4 into microsoft:main Mar 15, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants