Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line in Javadoc comment doesn't add the * prefix #30

Closed
mickaelistria opened this issue Mar 10, 2023 · 4 comments · Fixed by #31
Closed

New line in Javadoc comment doesn't add the * prefix #30

mickaelistria opened this issue Mar 10, 2023 · 4 comments · Fixed by #31

Comments

@mickaelistria
Copy link
Collaborator

From

/**
  * Blah blah
  */

Press Enter at the end of Blah blah line, a newline is created (good) but it misses the * prefix that can be inferred from the context.

@mickaelistria
Copy link
Collaborator Author

We're currently using the language-configuration from VSCode: https://github.com/microsoft/vscode/blob/main/extensions/java/language-configuration.json which doesn't include the necessary onEnterRules to enable it, unlike typescript language configuration for example.
However, this feature works in VSCode....
@rgrunber is it something VSCode Java brings?

@mickaelistria
Copy link
Collaborator Author

OK, I verified and this can be provided directly in the language-configuration. I'll fix it that way for the Eclipse integration and will submit a PR to VSCode as well; then you'll be able to remove those 30 lines from vscode-java.

@mickaelistria
Copy link
Collaborator Author

mickaelistria added a commit that referenced this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants