Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickpick tooltip not appearing #178067

Closed
DonJayamanne opened this issue Mar 22, 2023 · 7 comments
Closed

Quickpick tooltip not appearing #178067

DonJayamanne opened this issue Mar 22, 2023 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.77 Inisders
  • OS Version:

Steps to Reproduce:

  1. Install Jupyter extension
  2. Remove the python extension if installed
  3. Open a notebook and go into the kernel picker for Python Environments
  4. The quick pick item Install Python Extension shoudl have a tooltip

Originally reported by @connor4312
microsoft/vscode-jupyter#13086

I don't see a tooltip on the initial "install python" hint

image

@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@TylerLeonhardt
Copy link
Member

Image

I see it

@TylerLeonhardt
Copy link
Member

Anything in DevTools perhaps?

@TylerLeonhardt TylerLeonhardt added the info-needed Issue requires more information from poster label Mar 22, 2023
@DonJayamanne
Copy link
Contributor Author

@connor4312 /cc
Please can you check devtools.

@connor4312
Copy link
Member

No console errors.

But I debugged in compiled sources a little bit and saw that the quickpick item for the kernel picker is actually created here, and only the label is carried over, not the tooltip

for (const sourceAction of sourceActionCommands) {
const res: SourcePick = {
action: sourceAction,
picked: false,
label: sourceAction.action.label
};
quickPickItems.push(res);
}

@rebornix
Copy link
Member

Nice catch @connor4312 ❤️

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 23, 2023
@rebornix rebornix added this to the March 2023 milestone Mar 23, 2023
@DonJayamanne
Copy link
Contributor Author

However the Install Python Extension is not a kernel source, its a standard quick pick that is genrated by the Jupyter exetnsion and it works for me and tyler, but not for @connor4312
So, looks like the issue still exists even if we were to fix the issue identified above.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 23, 2023
@TylerLeonhardt TylerLeonhardt removed the unreleased Patch has not yet been released in VS Code Insiders label Mar 23, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants