Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Find widget has an empty space #178135

Closed
aeschli opened this issue Mar 23, 2023 · 3 comments · Fixed by #179398
Closed

Terminal: Find widget has an empty space #178135

aeschli opened this issue Mar 23, 2023 · 3 comments · Fixed by #179398
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Milestone
August 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 23, 2023 •
edited

Version: 1.77.0-insider (user setup)
Commit: a5bd844
Date: 2023-03-22T10:38:48.144Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22624
Sandboxed: Yes

  • open a terminal, press Ctrl + F
  • there's a gap behind the text field. It looks like it's a UI bug

image

I suggest to make the find widget consistent with the one from the editor

  • show No Results to avoid the gap
  • make it a but larger so the ghost text is readable
  • make it resizable
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget labels Mar 23, 2023
@Tyriar Tyriar added this to the Backlog milestone Mar 23, 2023
@tisilent
Copy link
Contributor

tisilent commented Apr 5, 2023

I want to try.

@tisilent
Copy link
Contributor

tisilent commented Apr 5, 2023

企业微信截图_16807116167777
adjusted sash style, height diff

tisilent added a commit to tisilent/vscode that referenced this issue Apr 6, 2023
@tisilent
Fix microsoft#178135
52771b9
@tisilent tisilent mentioned this issue Apr 6, 2023
Merged
@tisilent
Copy link
Contributor

tisilent commented Apr 7, 2023

20230407_143833

Tyriar added a commit to tisilent/vscode that referenced this issue Aug 4, 2023
@Tyriar
Merge branch 'main' into microsoft#178135
26f41a4
@Tyriar Tyriar modified the milestones: Backlog, August 2023 Aug 4, 2023
Tyriar added a commit that referenced this issue Aug 4, 2023
@Tyriar
Merge pull request #179398 from tisilent/#178135
2534d3a 
fix:Terminal find widget adjustment
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 4, 2023
@aeschli aeschli added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

fix:Terminal find widget adjustment tisilent/vscode
5 participants
@Tyriar @aeschli @meganrogge @tisilent @VSCodeTriageBot