provideDocumentSemanticTokens is called on all modified documents after a find/replace leading to the OS freezing #178461
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
semantic-tokens
Semantic tokens issues
verified
Verification succeeded
Milestone
Does this issue occur when all extensions are disabled?: Yes (but the repro requires an extension that implements semantic tokens)
Commit: ee2b180
Date: 2023-03-14T17:55:54.936Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No
and
Version: 1.77.0-insider (user setup)
Commit: b9226e1
Date: 2023-03-24T18:57:27.096Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes
Steps to Reproduce:
Bug: In addition to the didOpen, which is fine, VS Code is also invoking provideDocumentSemanticToken for the documents, which doesn't seem to make sense since the documents are not visible, which for the C/C++ extension can lead to the OS to freeze (we have a fix for that, see microsoft/vscode-cpptools#10743), but it seems like VS Code shouldn't be invoking provideDocumentSemanticToken in the first place. Our extension implements vscode.DocumentSemanticTokensProvider.
UPDATE: Also, looks like I had
not sure if that matters.
The text was updated successfully, but these errors were encountered: