Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.dev share urls with whitespace #178948

Closed
kieferrm opened this issue Apr 2, 2023 · 2 comments · Fixed by #179167
Closed

vscode.dev share urls with whitespace #178948

kieferrm opened this issue Apr 2, 2023 · 2 comments · Fixed by #179167
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Apr 2, 2023

For gh.com links we support perma link and head urls. For vscode.dev we only support perma links but I observe myself to need head links more than permalinks. We should add those.

Also, for file and folders with whitespace, the whitespace should be encoded, just like we do for the gh.com links we generate.

@joyceerhl joyceerhl added the feature-request Request for new features or functionality label Apr 3, 2023
@joyceerhl joyceerhl added this to the April 2023 milestone Apr 3, 2023
@joyceerhl
Copy link
Contributor

IMO vscode.dev links should be head links rather than permalinks. We could support both but I want to avoid clutter if possible.

Also, I do not see that we encode the whitespace for either github.com or vscode.dev links that we generate--will look into fixing for all our link code.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2023
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 21, 2023
@joyceerhl
Copy link
Contributor

Verification:

  1. Have pre-release of GitHub Pull Requests extension on desktop
  2. Open a desktop git clone of a GitHub repository on desktop
  3. Open a file
  4. Copy a vscode.dev link
  5. Verify that the link is a HEAD link (i.e. does not point to a specific commit sha)
  6. Open a GitHub repository on web (e.g. https://insiders.vscode.dev/github/microsoft/vscode)
  7. Repeat steps 2-4

@aiday-mar aiday-mar added the verified Verification succeeded label Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants