Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor position in centered layout mode gets reset #179566

Closed
ericmc2 opened this issue Apr 9, 2023 · 3 comments · Fixed by #198685
Closed

Editor position in centered layout mode gets reset #179566

ericmc2 opened this issue Apr 9, 2023 · 3 comments · Fixed by #198685
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@ericmc2
Copy link

ericmc2 commented Apr 9, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.0
  • OS Version: Windows 10 (x64)

Steps to Reproduce:

  1. Enable "Centered Layout".
  2. Reposition the editor by independently moving its sashes (holding down Alt).
  3. Exit and restart VS Code.

The position used to be remembered in previous versions, but starting with version 1.76, the position gets reset on every start. Only the width is being remembered. It's still broken in the current insider build of VS Code 1.78.0.

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Apr 10, 2023
@sbatten sbatten added this to the On Deck milestone Apr 10, 2023
@ShalokShalom
Copy link

Do we already know, which commit causes this regression?

@ericmc2
Copy link
Author

ericmc2 commented Sep 2, 2023

I looked through the commits for 1.76.0 and I suspect it was f6e1011.

@ShalokShalom
Copy link

Yeah, it is solved for me.

@joaomoreno joaomoreno assigned benibenj and unassigned sbatten Nov 5, 2023
@joaomoreno joaomoreno modified the milestones: On Deck, November 2023 Nov 5, 2023
benibenj added a commit that referenced this issue Nov 20, 2023
benibenj added a commit that referenced this issue Nov 21, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 21, 2023
@meganrogge meganrogge added the verified Verification succeeded label Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants