Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI - value description is not being read by Screen Reader #180115

Closed
BhanuPrakashGit opened this issue Apr 17, 2023 · 9 comments · Fixed by #183460
Closed

Settings UI - value description is not being read by Screen Reader #180115

BhanuPrakashGit opened this issue Apr 17, 2023 · 9 comments · Fixed by #183460
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X mitigated Issue has workaround in place settings-editor VS Code settings editor issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@BhanuPrakashGit
Copy link

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #Device; #Visual Studio Code Client; #BM-VisualStudioCodeClient-MAC-Oct2022; WCAG1.3.1; #Voiceover; #Screenreader; #Info and Relationships;

Environment and OS details:

Visual Studio Code Insiders
Screenreader: Voiceover

Repro Steps:

  1. Open Visual studio code editor
  2. Open the command Pallet and type "setting".
  3. Using down-arrow key select user setting.
  4. Type the word "Auto " and select one of the suggestion given by the vs code editor.
  5. Type the "Tab size" and select the option from the auto suggestion.
  6. Verify that Voiceover is not announcing the message which appears when focus comes on "Auto".

Actual Result:

Voiceover is not announcing the message (Remove adjacent quotes ....) which appears when focus comes on "Auto".

Expected Result:

Voiceover should announce the message (Remove adjacent quotes ....) which appears when focus comes on "Auto".

Attachment:

197955500-494e93b0-438e-4e22-9366-8c232174be82
198995371-aa7df2ce-cd65-468a-b9dc-6a2c5fd01826

@BhanuPrakashGit
Copy link
Author

Reference bug: #164699 (comment)

@rzhao271 rzhao271 added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process labels Apr 18, 2023
@rzhao271 rzhao271 added this to the May 2023 milestone Apr 18, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented May 25, 2023

@isidorn I noticed that on macOS on Chromium-based browsers, VoiceOver doesn't read the aria-label of a div if the role of the div is set to "option". I'm wondering whether we could remove the "option" role of the div elements for this specific case, i.e. custom selectboxes on macOS, as a workaround? I can also file an upstream issue with Chromium in the meantime.

@rzhao271 rzhao271 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) macos Issues with VS Code on MAC/OS X chromium Issues and items related to Chromium labels May 25, 2023
@rzhao271
Copy link
Contributor

I have filed an upstream issue with a min repro (minimal reproducible case) https://bugs.chromium.org/p/chromium/issues/detail?id=1448898.

rzhao271 added a commit that referenced this issue May 25, 2023
Acts as a workaround for and fixes #180115
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug mitigated Issue has workaround in place labels May 25, 2023
rzhao271 added a commit that referenced this issue May 25, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 25, 2023
@BhanuPrakashGit
Copy link
Author

Verified the bug in the environment:
Version: 1.45.0-insider (Universal)
Commit: b77ba86a99f525e81954414f9d717d90ccd2a1ca
Date: 2023-05-22T05:32:52.588Z
VS Code: 1.70.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 22.4.0
Bug is not fixed and still repro'ing.
Could you please reopen this issue.
180115_Reopened.zip

meganrogge pushed a commit that referenced this issue May 26, 2023
@rzhao271
Copy link
Contributor

@BhanuPrakashGit please try again with today's Insiders.

@BhanuPrakashGit
Copy link
Author

@rzhao271
Tried to download latest insiders but still we get the same version.
Version: 1.45.0-insider (Universal)
Commit: 2717a9b16d47cc4c4d5005068bc5fb3ee3de27c4
Date: 2023-05-26T05:31:07.551Z
VS Code: 1.70.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 22.4.0

Issue is still repro'ing. PFA for reference
Could you please share the downloading link for the latest insiders where fixes are available for this issue.
180115_NotFixed.zip

@fsteffi
Copy link

fsteffi commented May 30, 2023

#regressed:05-29-23;

@rzhao271
Copy link
Contributor

Hi @BhanuPrakashGit, that doesn't look like the right version of Insiders to me. Please try again after downloading the latest Insiders from https://code.visualstudio.com/Insiders/#osx.

@BhanuPrakashGit
Copy link
Author

GithubTags:#Regressed:05-31-23;#Closed;
Verified the bug in the environment:
Version: 1.79.0-insider (Universal)
Commit: fa8eefd
Date: 2023-05-31T03:12:18.068Z
Electron: 22.5.4
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.5.0

Bug is fixed and does not repro. Hence closing the bug.
PFA for reference.

180115_closed.zip

@ulugbekna ulugbekna added the verified Verification succeeded label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X mitigated Issue has workaround in place settings-editor VS Code settings editor issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants