Recommendation to search from Marketplace is not shown

[DanTup]

I opened VS Code with a brand new profile (--profile-temp --user-data-dir /foo/tmp) and opened .arb file. I was expected to see a notification "Marketplace has extensions that can help with '.arb' files" but nothing appeared.

I put a breakpoint inside promptRecommendations() in fileBasedRecommendations.ts and noticed that when this.recommendationsByPattern.get('.arb') is called, the set of extensions returned does not match those you get when yous earch "ext:arb" in the marketplace search. It returns a number of unrelated extensions, which are then discarded for not being ARB extensions, so ultimately no prompt is shown.

For example, in the list fetched in code is the Go extension, the CSharp extension, the Python extension, the PowerShell extension. But when I search the marketplace I get:

As a result, promptRecommendations never calls promptFromRecommendations, so promptRecommendedExtensionForFileType is also never called, which is where the file-type prompt is usually handled.

(@sandy081 FYI - I notice you made some changes in this area in #177181, so perhaps you have some context about how this works and whether this is a bug, or the behaviour is not exactly as I expect?).

[DanTup]

Thanks! :)

[isidorn]

We decided to remove the recommendation on file type extension feature. More details here #188467
Thank you!