Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup walkthrough does not open by default on first launch #181063

Closed
bhavyaus opened this issue Apr 27, 2023 · 4 comments · Fixed by #181066
Closed

Setup walkthrough does not open by default on first launch #181063

bhavyaus opened this issue Apr 27, 2023 · 4 comments · Fixed by #181066
Assignees
@digitarald @bhavyaus
Labels
bug Issue identified by VS Code Team member as probable bug getting-started verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2023

Comments

@bhavyaus
Copy link
Collaborator

bhavyaus commented Apr 27, 2023 •
edited
Loading

This scenario is flaky due to a timing issue between walkthroughs being registered and check for first open. I can repro this occasionally.
@bhavyaus bhavyaus added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Apr 27, 2023
@bhavyaus bhavyaus changed the title Setup walkthroughs do not open by default on first launch Setup walkthrough does not open by default on first launch Apr 27, 2023
@bhavyaus bhavyaus mentioned this issue Apr 27, 2023
Merged
@bhavyaus bhavyaus added this to the April 2023 milestone Apr 27, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 27, 2023
@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Apr 28, 2023
@meganrogge
Copy link
Contributor

@bhavyaus I think this should be on the May milestone?

@bhavyaus bhavyaus modified the milestones: April 2023, May 2023 May 30, 2023
@bhavyaus
Copy link
Collaborator Author

Verification Steps:

  1. Launch VS Code with a clean profile
    code-insiders --user-data-dir=$TMPDIR/cleanvsi/dir1 --extensions-dir=$TMPDIR/cleanvsi/ext-dir1
  2. Verify that the Setup walkthrough launches on startup.
image

@bhavyaus bhavyaus removed the verification-steps-needed Steps to verify are needed for verification label May 31, 2023
@DonJayamanne DonJayamanne added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verification-found Issue verification failed labels Jun 1, 2023
@DonJayamanne
Copy link
Contributor

Didn't work for me

  • Mac OS

Screenshot 2023-06-01 at 11 54 28

@DonJayamanne DonJayamanne reopened this Jun 1, 2023
@DonJayamanne DonJayamanne removed the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Jun 1, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 1, 2023
@meganrogge meganrogge removed the candidate Issue identified as probable candidate for fixing in the next release label Jun 1, 2023
@bhavyaus
Copy link
Collaborator Author

bhavyaus commented Jun 1, 2023

I can repro this on the mac. Works as expected on windows.

@bhavyaus bhavyaus modified the milestones: May 2023, June 2023 Jun 1, 2023
@bhavyaus bhavyaus removed the verification-found Issue verification failed label Jun 11, 2023
@bhavyaus bhavyaus added the verification-needed Verification of issue is requested label Jun 11, 2023
@andreamah andreamah added the verified Verification succeeded label Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@digitarald digitarald

@bhavyaus bhavyaus

Labels
bug Issue identified by VS Code Team member as probable bug getting-started verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2023
7 participants
@digitarald @jrieken @DonJayamanne @bhavyaus @meganrogge @andreamah @VSCodeTriageBot