Move opening default built-in walkthrough to after built-in walkthrough initialization #181066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #181063
The issue affects new user experience
Issue:
The built-in walkthrough registration was recently changed to be asynchronous with 06dbbfa#diff-ef0653ae93121f64b9d756dff8460099cba11fc175134d2ff193b671fe3f9003
This causes a timing issue with the check for opening the Setup walkthrough occurring before the built-in walkthroughs have finished resolving.
Fix :
Moved up the code to check/open the Setup walkthrough into the event handler
onDidAddBuiltInWalkthrough. (Ideally, we would change up the gettingStartedService to be async but that is a larger fix I do not wish to make currently).