Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance after 1.77 update #181434

Closed
mjbvz opened this issue May 3, 2023 · 15 comments
Closed

Slow performance after 1.77 update #181434

mjbvz opened this issue May 3, 2023 · 15 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 3, 2023

@mjbvz
It happened for me in all code repos I tried, including public ones such as https://github.com/microsoft/vscode/. For now I can't point to specific location in code and editing action where this problem reproduces 100%.

I can only confirm that disabling error handler telemetry (e.g. with sergei-dyshel@122c48b) eliminates the issue.

When I have some more time I'll try to investigate it a bit more.

Originally posted by @sergei-dyshel in #178799 (comment)

@mjbvz
Copy link
Contributor Author

mjbvz commented May 3, 2023

@jrieken Can you investigate this. The reporter suggests it may be related to extension host exception handling

@DPRIYATHAM
Copy link

I do have the same issue, before I checked this issues section, I thought some issue with my laptop and reinstalled vs code, still issue hadn't resolved, then I realized it is 1.77v problem after viewing this issue, thanks for making this issue, else I would be sitting the whole night to debug the issue. 💀

@jrieken
Copy link
Member

jrieken commented May 4, 2023

/needsMoreInfo

Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues#startup-timer. Thanks.

@VSCodeTriageBot VSCodeTriageBot added the ~info-needed Issue requires more information from poster (with bot comment) label May 4, 2023
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels May 4, 2023
@sergei-dyshel
Copy link

@jrieken
May I ask how is startup time is related here? The slowness happens during using language features, not on start.

Instead, can you provide information/link to guide on how to debug extension host itself? Particularly I'm interested:

  1. Putting breakpoints in exthost code - I can put breakpoint in error handler to see when prepareStackTrace.
  2. Adding debugging logs to exthost.
  3. Existing PerformanceObserver/Histogram infrastracture that I can use to add error handler histograms by plugin.

@DPRIYATHAM
Copy link

@mjbvz is the issue resolved for you?
Is vs code starting normally?
Or are you still facing some issues while start up?
If you issue is solved please do let me know how you solved it,
Please help me to solve this slow start issue. 🥲

@hasokeric
Copy link

I am facing the same issue I am on the latest build Insiders.

@maccman
Copy link

maccman commented Jun 4, 2023

Same here

@hasokeric
Copy link

@maccman
Copy link

maccman commented Jun 6, 2023

@hasokeric Me too - downgrade worked for me.

For any core-team members reading this, this seems like a real problem.

@DavidAmunga
Copy link

Thanks @hasokeric , Downgrade worked for me well. Hopefully this is resolved soon by the core team.

@maccman
Copy link

maccman commented Jun 10, 2023

@jrieken bump :)

@jrieken
Copy link
Member

jrieken commented Jun 14, 2023

Still needs actionable information. Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues and/or "F1 > Start Extension Bisect" to provide more information

@hasokeric
Copy link

Is this the related issue, finally someone caught it? We should be able to see if it solves it in the next minor releases, perhaps insiders... #184926

@jrieken
Copy link
Member

jrieken commented Jun 23, 2023

closing that either dupe of #184926 or not actionable as no further information has been delivered

@jrieken jrieken closed this as completed Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

8 participants