Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treeView.reveal with expand: 3 only expands the first level 3 folder #181889

Closed
david-tejada opened this issue May 9, 2023 · 4 comments · Fixed by #182295
Closed

treeView.reveal with expand: 3 only expands the first level 3 folder #181889

david-tejada opened this issue May 9, 2023 · 4 comments · Fixed by #182295
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
May 2023

Comments

@david-tejada
Copy link

  • VS Code Version: 1.79.0-insider
  • OS Version: macOS 12.6.3

I am working on a file explorer tree view extension and treeView.reveal doesn't work properly if expand is 2 or 3. When expand is 3 only the first level 3 folder expands. I have checked and getChildren doesn't get called for the rest of the level 3 folders. If I call reveal again with expand: 3 the rest of the level 3 folders expand.

When I use treeView.reveal with expand 2 or 3 on a large folder (hundreds of items) the promise never fulfills even though the folder expands (at least up to level 2).

I don't get any error in any of the two cases.
@lramos15 lramos15 assigned alexr00 and unassigned lramos15 May 9, 2023
@alexr00
Copy link
Member

alexr00 commented May 10, 2023

@david-tejada can you share a minimal example that reproduces this issue?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label May 10, 2023
@david-tejada
Copy link
Author

Sure thing, here you have it: david-tejada/vscode-expand-treeitem: Minimal reproducible example for vscode issue #181889

@alexr00
Copy link
Member

alexr00 commented May 12, 2023

Thank you for the repro repo!

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues and removed info-needed Issue requires more information from poster labels May 12, 2023
@alexr00 alexr00 added this to the May 2023 milestone May 12, 2023
@alexr00 alexr00 mentioned this issue May 12, 2023
Merged
alexr00 added a commit that referenced this issue May 12, 2023
@alexr00
treeView.reveal with expand: 3 only expands the first level 3 folder
5911b64 
Fixes #181889
alexr00 added a commit that referenced this issue May 12, 2023
@alexr00
treeView.reveal with expand: 3 only expands the first level 3 fol…
48d4ba2 
…der (#182295)

Fixes #181889
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 12, 2023
@david-tejada
Copy link
Author

No problem, thanks for the fix!

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 15, 2023
@david-tejada david-tejada mentioned this issue May 15, 2023
Merged
@andreamah andreamah added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

treeView.reveal with expand: 3 only expands the first level 3 folder microsoft/vscode
5 participants
@david-tejada @lramos15 @andreamah @alexr00 @VSCodeTriageBot