Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace only diffs should be highlighted somehow regardless of settings #182087

Closed
Tyriar opened this issue May 10, 2023 · 2 comments · Fixed by #200132
Closed

Whitespace only diffs should be highlighted somehow regardless of settings #182087

Tyriar opened this issue May 10, 2023 · 2 comments · Fixed by #200132
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Milestone
December / Januar...

Comments

@Tyriar
Copy link
Member

Tyriar commented May 10, 2023

This diff confused me for a bit.

image

There's a trailing space at the end of the line but it's not highlighted. This would be even more confusing if you have non-visible whitespace (I think that's the default).
@Tyriar Tyriar added the under-discussion Issue is under discussion for relevance, priority, approach label May 10, 2023
@lszomoru lszomoru assigned hediet and unassigned lszomoru May 11, 2023
@hediet
Copy link
Member

hediet commented May 12, 2023

I bet you disabled whitespace diffing. Why should this setting be ignored now?

@Tyriar
Copy link
Member Author

Tyriar commented May 12, 2023

I have "diffEditor.ignoreTrimWhitespace": false set, which means whitespace should show right? Setting to true doesn't show it either. Am I looking at the wrong setting?

The why even if it's ignored is I click for more info and it shows nothing which confused me, I can understand why you wouldn't want to handle it specially though.

@hediet hediet added this to the Backlog milestone May 22, 2023
@hediet hediet added diff-editor Diff editor issues bug Issue identified by VS Code Team member as probable bug labels May 22, 2023
hediet added a commit that referenced this issue Dec 6, 2023
@hediet
Fixes #182087
c6a4848
@hediet hediet mentioned this issue Dec 6, 2023
Merged
@hediet hediet modified the milestones: Backlog, December 2023 Dec 6, 2023
hediet added a commit that referenced this issue Dec 6, 2023
@hediet
Fixes #182087
46e4357
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
@benibenj benibenj added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

Fixes #182087 microsoft/vscode
6 participants
@Tyriar @hediet @lszomoru @benibenj @aiday-mar @VSCodeTriageBot