Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrapping enabled through the menu is reset whenever settings.json is modified #18210

Closed
rotemdan opened this issue Jan 6, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@rotemdan
Copy link

rotemdan commented Jan 6, 2017

  • VSCode Version:
    1.8.1, latest insider build
  • OS Version:
    Windows 10 x64

Steps to Reproduce:

  1. Make sure that wrapping isn't permanently enabled, and if it is, remove any permanent setting related to wrapping.
  2. Open a file that contains lines longer than the width of the screen.
  3. Enable word wrapping through View -> Toggle Word Wrap.
  4. Modify one character in settings.json and save it.
  5. Word wrapping should be unexpectedly disabled.

This behavior makes extensions that modify configuration based on user actions, constantly reset the wrapping setting. For example this issue with vscode-spellchecker where the wrapping is reset every time the user selects to "always ignore" a word because that action causes settings.json to be modified with the newly ignored word.

@rotemdan
Copy link
Author

rotemdan commented Jan 6, 2017

Seems like the same behavior happens with the Toggle Render Whitespace and Toggle Control Characters menu options as well.

@alexdima
Copy link
Member

alexdima commented Jan 9, 2017

Test plan item is #18316

@rotemdan
Copy link
Author

The quick response was amazing! I'm already seeing this on the Insider build. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants