Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNC host allow list should be case insensitive #182277

Closed
geniuszxy opened this issue May 12, 2023 · 5 comments · Fixed by #183116
Closed

UNC host allow list should be case insensitive #182277

geniuszxy opened this issue May 12, 2023 · 5 comments · Fixed by #183116
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan unc under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@geniuszxy
Copy link

geniuszxy commented May 12, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.2
  • OS Version: 10.0.19044

Steps to Reproduce:

  1. My project is under the unc path "\\UBUNTUX" so I add "UBUNTUX" to the Allowed UNCHosts setting.
  2. Try to open the file "\\ubuntux\sample.txt", a dialog says "The host 'ubuntux' was not found in the list of allowed hosts."

Paths on Windows are case insensitive, so IMO this setting should use the same rule.
This is not just an openning file issue, some extensions are using lowercase paths to process files, so actually I get many errors related to this issue. Now I have to add both "UBUNTUX" and "ubuntux" to the setting which is redundance.

@bpasero bpasero added under-discussion Issue is under discussion for relevance, priority, approach unc and removed triage-needed new release labels May 12, 2023
@bpasero bpasero assigned bpasero and deepak1556 and unassigned jrieken May 12, 2023
@bpasero bpasero added this to the May 2023 milestone May 12, 2023
@bpasero bpasero changed the title The Allowed UNCHosts setting is case sensitive UNC host allow list should be case insensitive May 12, 2023
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels May 15, 2023
@Liturgist
Copy link

I entered the UNC name in Settings as SERVER01.
I tried to open a file \\SERVER01\CODE\path\to\file.txt.
The error message appears to have changed the case.

Unable to read file '\\Server01\code\path\to\file.txt'

If I add Server01 as an allowed UNC host, it will work as expected.

@Liturgist
Copy link

Liturgist commented May 17, 2023

  1. My project is under the unc path "\\UBUNTUX" so I add "UBUNTUX" to the Allowed UNCHosts setting.
  2. Try to open the file "\\ubuntux\sample.txt", a dialog says "The host 'ubuntux' was not found in the list of allowed hosts."

Try adding Ubuntux to the Allowed UNCHosts list.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 22, 2023
bpasero added a commit that referenced this issue May 22, 2023
* UNC host allow list should be case insensitive (fix #182277)

* only use `toLowerCase()`
@bpasero
Copy link
Member

bpasero commented May 22, 2023

The fix for this change will go out at the end of this week in our insiders build [1] and early June in stable build.

[1] Insiders builds normally release every day but are currently on-hold given the MSBuild conference that takes place.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 25, 2023
@deepak1556 deepak1556 added the author-verification-requested Issues potentially verifiable by issue author label May 26, 2023
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@geniuszxy, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 52e56ad of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@geniuszxy
Copy link
Author

/verified

@VSCodeTriageBot VSCodeTriageBot removed the author-verification-requested Issues potentially verifiable by issue author label May 29, 2023
@VSCodeTriageBot VSCodeTriageBot added the verified Verification succeeded label May 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan unc under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants