Contributed icon in JS debug terminal stopped working

[Tyriar]

See microsoft/vscode-js-debug#975 (comment)

I can reproduce:

[tisilent]

I want to try.

[Tyriar]

@tisilent sure! This is where the profile info is pulled in:

vscode/src/vs/workbench/contrib/terminal/common/terminalExtensionPoints.ts

Lines 23 to 50 in b725a17

	export class TerminalContributionService implements ITerminalContributionService {
	declare _serviceBrand: undefined;
	private _terminalProfiles: ReadonlyArray<IExtensionTerminalProfile> = [];
	get terminalProfiles() { return this._terminalProfiles; }
	constructor() {
	terminalsExtPoint.setHandler(contributions => {
	this._terminalProfiles = contributions.map(c => {
	return c.value?.profiles?.filter(p => hasValidTerminalIcon(p)).map(e => {
	return { ...e, extensionIdentifier: c.description.identifier.value };
	}) || [];
	}).flat();
	});
	}
	}
	function hasValidTerminalIcon(profile: ITerminalProfileContribution): boolean {
	return !profile.icon ||
	(
	typeof profile.icon === 'string' ||
	URI.isUri(profile.icon) ||
	(
	'light' in profile.icon && 'dark' in profile.icon &&
	URI.isUri(profile.icon.light) && URI.isUri(profile.icon.dark)
	)
	);
	}