Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up getting started async #182947

Merged
merged 2 commits into from May 19, 2023
Merged

Clean up getting started async #182947

merged 2 commits into from May 19, 2023

Conversation

bhavyaus
Copy link
Contributor

  1. Changed the gettingStartedService to be async and cleaned up code.
  2. Also changed welcome page startup to wait for all services to be ready before rendering which prevents the UI from updating immediately after launching vscode. Also moved the remote start entry contribution to help with this.

Tested

  1. Launch with no extensions installed.
  2. Launch with extensions installed
  3. UI after extension installed
  4. UI after extension uninstalled
  5. Quicks picks from the Command Palette and more option

@VSCodeTriageBot VSCodeTriageBot added this to the May 2023 milestone May 19, 2023
@bhavyaus bhavyaus merged commit 6d90c12 into main May 19, 2023
6 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/startup branch May 19, 2023 15:48
This was referenced May 23, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 8, 2023
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@bhavyaus bhavyaus

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhavyaus @sandy081 @VSCodeTriageBot