Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading suggestions or autocomplete of extensions #183030

Closed
jeanbrazcosta opened this issue May 20, 2023 · 10 comments · Fixed by #183965
Closed

Reading suggestions or autocomplete of extensions #183030

jeanbrazcosta opened this issue May 20, 2023 · 10 comments · Fixed by #183965
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@jeanbrazcosta
Copy link

Type: Feature Request

Depending on the extension we are using, when code suggestion information appears, it is not read by screen readers.

Steps to reproduce.

Install the codeium extension.

Open any project, and start typing or commenting the code;

You will hear a sound when a hint appears, but this hint is not read by screen readers like nvda.

I suggest that it is possible to activate a configuration in vscode, so that this type of information can be transmitted to screen readers.

VS Code version: Code - Insiders 1.79.0-insider (f6be546, 2023-05-20T01:18:53.811Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Remote OS version: Linux x64 5.15.90.1-microsoft-standard-WSL2

@meganrogge
Copy link
Contributor

I can reproduce. We must not be getting the line content here

const lineText = model.textModel.getLineContent(state.ghostText.lineNumber);
alert(state.ghostText.renderForScreenReader(lineText));

@jeanbrazcosta
Copy link
Author

@meganrogge I would like to inform you that I also tested it with the copilot and when listening to the sound that a suggestion was given, the screen readers also do not read.

@meganrogge
Copy link
Contributor

You need to set editor.screenReaderAnnounceInlineSuggestion to true and it will work for copilot @jeanbrazcosta

@meganrogge
Copy link
Contributor

@jooyoungseo do you think we should now set that to true by default?

@jeanbrazcosta
Copy link
Author

jeanbrazcosta commented May 30, 2023

Nice @meganroggeI defined it and it actually worked for the copilot.

My suggestion is that it would not be possible for these settings to go to the accessibility feature?

I know that it makes sense to stay where they are because it has to do with the editor, but they are difficult to find, or maybe we have some dock where all the accessibility features are and their respective paths where they should be activated, you get the idea.

@meganrogge
Copy link
Contributor

Yes, we actually have help menus now for the copilot chat view / interactive editor session. When you focus those inputs, using alt+f1 reveals/focuses the help menu for each.

I think for this case, we should enable inline suggestion by default

@meganrogge meganrogge added this to the May 2023 milestone May 30, 2023
@jeanbrazcosta
Copy link
Author

jeanbrazcosta commented May 30, 2023

Sorry, @meganrogge just found out that by enabling the setting, it also worked for codeium.

Should I then close this issue?

@hediet hediet modified the milestones: May 2023, June 2023 May 30, 2023
@meganrogge meganrogge removed this from the June 2023 milestone May 31, 2023
@meganrogge meganrogge reopened this May 31, 2023
@meganrogge
Copy link
Contributor

I think we should enable this by default, so will use this issue to track that

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels May 31, 2023
@jooyoungseo
Copy link

@meganrogge I agree with the idea setting the inline suggestion announcement to TRUE by default as it is now stable.

@meganrogge meganrogge added this to the May 2023 milestone May 31, 2023
meganrogge added a commit that referenced this issue May 31, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 31, 2023
@Tyriar Tyriar added the verified Verification succeeded label Jun 1, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

Verified the setting default is flipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants