Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminals aren't persisting anymore #183445

Closed
meganrogge opened this issue May 25, 2023 · 1 comment 路 Fixed by #183516
Closed

Terminals aren't persisting anymore #183445

meganrogge opened this issue May 25, 2023 · 1 comment 路 Fixed by #183516
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone
May 2023

Comments

@meganrogge
Copy link
Contributor

  1. Create terminals, type in them
  2. Reload the window
  3. 馃悰 they aren't persisted
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive labels May 25, 2023
@meganrogge meganrogge added this to the May 2023 milestone May 25, 2023
@jeanp413 jeanp413 mentioned this issue May 26, 2023
Merged
jeanp413 added a commit to jeanp413/vscode that referenced this issue May 26, 2023
@jeanp413
Fixes microsoft#183445
677be08
@jeanp413
Copy link
Contributor

PR fixing it #183516

@meganrogge meganrogge mentioned this issue May 26, 2023
Closed
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 27, 2023
@ulugbekna ulugbekna added the verified Verification succeeded label Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Fix Terminals aren't persisting anymore jeanp413/vscode
5 participants
@Tyriar @ulugbekna @jeanp413 @meganrogge @VSCodeTriageBot