Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Go to project configuration' doesn't work on web #183685

Closed
mjbvz opened this issue May 28, 2023 · 13 comments · Fixed by #183688
Closed

'Go to project configuration' doesn't work on web #183685

mjbvz opened this issue May 28, 2023 · 13 comments · Fixed by #183688
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 28, 2023

  1. Open https://insiders.vscode.dev/github/microsoft/vscode-markdown-languageservice
  2. Go to a ts file
  3. Try to run go to project configuration or click on the open tsconfig option in the language status

bug
Nothing happens

Version: 1.79.0-insider
Commit: 2dfb838
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Safari/605.1.15
Embedder: vscode.dev

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web labels May 28, 2023
@mjbvz mjbvz added this to the May 2023 milestone May 28, 2023
@mjbvz mjbvz self-assigned this May 28, 2023
@mjbvz mjbvz modified the milestones: May 2023, June 2023 May 28, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue May 28, 2023
mjbvz added a commit that referenced this issue May 30, 2023
…stems (#183688)

Make `go to project` commands work on non-`file:` file systems

Fixes #183685
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 30, 2023
@mjbvz mjbvz modified the milestones: June 2023, May 2023 May 30, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 31, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

When I run the command (file under src/util) I always get this notification:

image

No tsconfig here:

image

@Tyriar Tyriar reopened this Jun 1, 2023
@Tyriar Tyriar added the verification-found Issue verification failed label Jun 1, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 1, 2023
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 1, 2023

What file were you in?

Screenshot 2023-06-01 at 9 48 03 AM

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

Above was src/util/schemes.ts and src/logging.ts.

src/languageFeatures/definitions.ts:

image

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 1, 2023

I can't repo in safari or chrome. Do other project wide Intellisense features work for you? Try running find all references to check

@mjbvz mjbvz modified the milestones: May 2023, June 2023 Jun 1, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

It takes a long time to activate like that other issue I created, but when it does, it still shows no tsconfig:

image

@mjbvz mjbvz modified the milestones: June 2023, July 2023 Jun 22, 2023
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 10, 2023

@Tyriar Can you please test this again. It possible you were running into the issue fixed by 3a02b99 that would caused the repo archive not to download

@mjbvz mjbvz removed the verification-found Issue verification failed label Jul 10, 2023
@Tyriar
Copy link
Member

Tyriar commented Jul 11, 2023

Still happens, both during and after init TS status bar item is there:

image
image

Microsoft Edge
Version 116.0.1938.10 (Official build) dev (64-bit)

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 11, 2023

@Tyriar Weird, this always works for me across Safari, Chrome, and Edge. Init is also almost instant

Can you try sharing the output log from TypeScript. At the top it should say:

2023-07-11 11:09:27.033 [info] Successfully loaded workspace content for repository vscode-vfs://github/microsoft/vscode-markdown-languageservice

@Tyriar
Copy link
Member

Tyriar commented Jul 11, 2023

@mjbvz

2023-07-11 11:22:12.770 [info] Successfully loaded workspace content for repository vscode-vfs://github/microsoft/vscode-markdown-languageservice
2023-07-11 11:22:12.770 [info] Starting TS Server undefined
2023-07-11 11:22:12.770 [info] Using tsserver from: https://main.vscode-cdn.net/insider/f8782370c90ec98467dc3590bcfa2eeb1f218107/extensions/typescript-language-features/dist/browser/typescript/tsserver.web.js undefined
2023-07-11 11:22:12.770 [info] <syntax> Forking...
2023-07-11 11:22:12.770 [info] <syntax> Starting...
2023-07-11 11:22:12.770 [info] <semantic> Forking...
2023-07-11 11:22:12.770 [info] <semantic> Starting...

@Tyriar
Copy link
Member

Tyriar commented Jul 11, 2023

Tried to get trace logs but ran into #187622

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 18, 2023

@Tyriar After changing the log level, can you try running Restart TS Server with a ts file open. That should restart the server and generate new logs

@Tyriar
Copy link
Member

Tyriar commented Jul 18, 2023

@mjbvz it's working now 🤷

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 20, 2023

Ok thanks for testing all these times. If you see it not working again, please try collecting the full logs. I suspect it's more than just go to project configuration that's broken in those cases

@mjbvz mjbvz closed this as completed Jul 20, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants