Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty value in markdown.copyFiles.destination sends the image to the parent directory #183848

Closed
roblourens opened this issue May 30, 2023 · 0 comments · Fixed by #183864
Closed

Empty value in markdown.copyFiles.destination sends the image to the parent directory #183848

roblourens opened this issue May 30, 2023 · 0 comments · Fixed by #183864
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone
May 2023

Comments

@roblourens
Copy link
Member

Testing #183682

When I set up the markdown.copyFiles.destination setting, but leave the value empty, the image goes to the parent directory of the workspace folder, which seems unexpected. I think I would want it to keep the default behavior of going next to the markdown file. Just testing this because settings like this are often confusing so I think it should have good failure modes.
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels May 30, 2023
@mjbvz mjbvz added this to the May 2023 milestone May 30, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue May 30, 2023
@mjbvz
Default to filename for markdown new file if empty
6607b81 
Fixes microsoft#183848
@mjbvz mjbvz mentioned this issue May 30, 2023
Merged
mjbvz added a commit that referenced this issue May 30, 2023
@mjbvz
Default to filename for markdown new file if empty (#183864)
d933dbd 
Fixes #183848
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2023
@roblourens roblourens added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Default to filename for markdown new file if empty mjbvz/vscode
3 participants
@roblourens @mjbvz @VSCodeTriageBot