Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't do regex search after opening notebook #183858

Closed
roblourens opened this issue May 30, 2023 · 1 comment · Fixed by #183884
Closed

Can't do regex search after opening notebook #183858

roblourens opened this issue May 30, 2023 · 1 comment · Fixed by #183884
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

  • Open a notebook
  • I want to do a regex search in normal text files in my workspace, but the option is disabled
image

This caught me off guard, I see that I have to disable searching in rendered markdown to enable regex mode, which makes sense, but I don't want to search in notebooks right now. Does it search in rendered markdown by default?

One thing that would be helpful would be to have a tooltip to tell me why regex search is disabled

@andreamah andreamah added search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug labels May 30, 2023
@andreamah andreamah added this to the May 2023 milestone May 30, 2023
@andreamah
Copy link
Contributor

andreamah commented May 30, 2023

I believe that I originally had it like this because notebook outputs and markdown preview doesn't support regex search, but I agree that it's unexpected to just disable regex straight-out. For now, I'm going to keep regex enabled no matter which options in the notebook find widget are checked (since, by default, all are checked).

That would probably have a smaller impact on users, since it'll just do a plain non-regex search when looking in outputs/previews. Will do full fix (finding better way to convey to users that outputs/previews can't be regex searched) in #183882.

andreamah added a commit that referenced this issue May 30, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2023
@Tyriar Tyriar added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants