Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce does not appear to work on fish shell #183972

Open
connor4312 opened this issue May 31, 2023 · 3 comments
Open

Nonce does not appear to work on fish shell #183972

connor4312 opened this issue May 31, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-shell-fish An issue in the terminal specific to fish terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@connor4312
Copy link
Member

connor4312 commented May 31, 2023

Testing #181522

Other shells are okay, but fish shell did not appear to have a nonce, and prompted for confirmation when rerunning a command

image
@Tyriar
Copy link
Member

Tyriar commented May 31, 2023

@connor4312 do you have an old shell integration setup in your ~/.config/fish/fish.config?

@Tyriar Tyriar added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. terminal-shell-fish An issue in the terminal specific to fish and removed info-needed Issue requires more information from poster labels May 31, 2023
@Tyriar Tyriar added this to the May 2023 milestone May 31, 2023
@connor4312
Copy link
Member Author

I don't think so, these are its contents:

if status is-interactive
    # Commands to run in interactive sessions can go here
end
set -gx VOLTA_HOME "$HOME/.volta"
set -gx PATH "$VOLTA_HOME/bin" $PATH

@Tyriar Tyriar modified the milestones: May 2023, June 2023 Jun 1, 2023
@Tyriar Tyriar modified the milestones: June 2023, Backlog Jun 26, 2023
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Dec 5, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 5, 2023

Code pointer:

# Handle the shell integration nonce
if set -q VSCODE_NONCE
set -l __vsc_nonce $VSCODE_NONCE
set -e VSCODE_NONCE
end

To verify/reproduce this:

  1. Open fish shell, make sure shell integration is enabled
  2. Run a command
  3. Click the blue circle to the left of the prompt and select Rerun Command, 🐛 it should run immediately and not show a confirmation dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-shell-fish An issue in the terminal specific to fish terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

No branches or pull requests

2 participants