Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a nonce to verify shell integration command lines #181522

Closed
Tyriar opened this issue May 4, 2023 · 1 comment · Fixed by #181523
Closed

Use a nonce to verify shell integration command lines #181522

Tyriar opened this issue May 4, 2023 · 1 comment · Fixed by #181523
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 4, 2023

This is a follow up to improve the UX of rerunning and trusting a command line from shell integration scripts #179701

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. labels May 4, 2023
@Tyriar Tyriar added this to the May 2023 milestone May 4, 2023
@Tyriar Tyriar self-assigned this May 4, 2023
Tyriar added a commit that referenced this issue May 4, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 4, 2023
@Tyriar
Copy link
Member Author

Tyriar commented May 26, 2023

To verify repeat these steps for each shell type (bash, zsh, fish, pwsh):

  1. Open a terminal and ensure shell integration is activated
  2. Run the toggle escape sequence logging command
  3. Run a command in the terminal, verify you see a line with a guid in the escape sequence log like this:
    Screenshot 2023-05-26 at 9 51 03 am
  4. Click the shell integration decoration and select rerun command, verify that it reruns the command immediately, without a confirmation prompt
    Screenshot 2023-05-26 at 9 51 52 am
  5. For bash only run echo -e '\x1b]633;E;fake', verify that you get a confirmation prompt

@Tyriar Tyriar added the verification-needed Verification of issue is requested label May 26, 2023
@connor4312 connor4312 added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants