Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computing the diff is very slow #184037

Closed
alexdima opened this issue Jun 1, 2023 · 0 comments · Fixed by #185664
Closed

Computing the diff is very slow #184037

alexdima opened this issue Jun 1, 2023 · 0 comments · Fixed by #185664
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2023

Comments

@alexdima
Copy link
Member

alexdima commented Jun 1, 2023

I think this is caused by running word level diff over the large change:
image

The legacy algorithm would not do this:
image
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels Jun 1, 2023
@hediet hediet added this to the June 2023 milestone Jun 1, 2023
yshaojun added a commit to yshaojun/vscode that referenced this issue Jun 17, 2023
@yshaojun
fix: computing diff slow(microsoft#184037)
1ed8da9
@yshaojun yshaojun mentioned this issue Jun 17, 2023
Closed
@hediet hediet mentioned this issue Jun 20, 2023
Merged
hediet added a commit that referenced this issue Jun 20, 2023
@hediet
Fixes #184037
2e69633
hediet added a commit that referenced this issue Jun 20, 2023
@hediet
Fixes #184037
87b04a9
hediet added a commit that referenced this issue Jun 20, 2023
@hediet
Fixes #184037 (#185664)
70abe7e
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 20, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

Fixes #184037 microsoft/vscode
fix: computing diff slow(#184037) yshaojun/vscode
4 participants
@hediet @alexdima @rzhao271 @VSCodeTriageBot