Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Port Attributes constructor #184412

Merged
merged 1 commit into from Jun 6, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jun 6, 2023

Fixes #183850

@alexr00 alexr00 self-assigned this Jun 6, 2023
@alexr00 alexr00 changed the base branch from main to release/1.79 June 6, 2023 12:46
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 6, 2023
@alexr00 alexr00 modified the milestones: June 2023, May 2023 Jun 6, 2023
@alexr00
Copy link
Member Author

alexr00 commented Jun 6, 2023

When I updated the API to deprecate the old constructor, the bad type check broke the API for the Jupyter extension. It's safe to remove the old constructor entirely because all extensions that rely on the old constructor have moved off of it.
There are 2 current users of this API:

@alexr00 alexr00 force-pushed the alexr00/portAttributesConstructor branch from d850cd0 to b82b9bf Compare June 6, 2023 13:13
@alexr00 alexr00 merged commit aee5255 into release/1.79 Jun 6, 2023
6 checks passed
@alexr00 alexr00 deleted the alexr00/portAttributesConstructor branch June 6, 2023 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PortAutoForwardAction's opening commands not working
4 participants