Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird gap between selected cells #184434

Closed
rebornix opened this issue Jun 6, 2023 · 2 comments
Closed

Weird gap between selected cells #184434

rebornix opened this issue Jun 6, 2023 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-multiselect verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone
June 2023

Comments

@rebornix
Copy link
Member

rebornix commented Jun 6, 2023

image

There is a gap between selected cells when we have multi cells selection.
@rebornix rebornix self-assigned this Jun 6, 2023
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-multiselect labels Jun 6, 2023
@rebornix rebornix added this to the June 2023 milestone Jun 6, 2023
rebornix added a commit that referenced this issue Jun 6, 2023
@rebornix
Fix #184434. Remove bg gap between selected cells
a3bcc58
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 6, 2023
@bhavyaus bhavyaus added the ~verification-steps-needed Steps to verify are needed (with bot comment) label Jun 28, 2023
@VSCodeTriageBot
Copy link
Collaborator

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@VSCodeTriageBot VSCodeTriageBot added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels Jun 28, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 29, 2023
@rzhao271
Copy link
Contributor

I'm unsure if what I'm seeing is expected:

GitHub Issue Notebooks

Multiselect containing Markdown and code cells

Jupyter Notebook (Python cells only)

Multiselect only containing code cells

Jupyter Notebook (including rendered Markdown cells)

Multiselect starting with a Markdown cell on top to one on the bottom

For the last scenario, I selected a top cell first, and then shift-clicked a bottom cell.

@rebornix rebornix mentioned this issue Jun 29, 2023
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-multiselect verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Milestone
June 2023
Development

No branches or pull requests
4 participants
@rebornix @rzhao271 @bhavyaus @VSCodeTriageBot