Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback of default log level for a channel is confusing #185342

Closed
Tyriar opened this issue Jun 16, 2023 · 1 comment · Fixed by #185738
Closed

Feedback of default log level for a channel is confusing #185342

Tyriar opened this issue Jun 16, 2023 · 1 comment · Fixed by #185738
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2023

Repro:

  1. Set default log level for all channels to debug
  2. Set default log level for pty host to trace
  3. Run the set log level command

This is the quick pick that shows, this is good:

image

When I click into the pty host it shows that debug is the default, which is the default for all channels, not the pty host specifically:

image

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 16, 2023
@sandy081 sandy081 added the log VS Code log issues label Jun 20, 2023
@sandy081 sandy081 added this to the June 2023 milestone Jun 20, 2023
sandy081 added a commit that referenced this issue Jun 21, 2023
@sandy081
Copy link
Member

This is because we do not support setting default log level per logger in core. It can be configured for core + extensions only. This action shown in UI for core loggers is a bug.

sandy081 added a commit that referenced this issue Jun 21, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 21, 2023
@Tyriar Tyriar added the verified Verification succeeded label Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants