remove setting with no effect #186187
Merged
remove setting with no effect #186187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
reviewed
Jun 26, 2023
| @@ -791,11 +791,6 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis | |||
| type: 'boolean', | |||
| default: true, | |||
| markdownDescription: localize('interactiveWindow.alwaysScrollOnNewCell', "Automatically scroll the interactive window to show the output of the last statement executed. If this value is false, the window will only scroll if the last cell was already the one scrolled to.") | |||
| }, | |||
| [InteractiveWindowSetting.interactiveWindowRestore]: { | |||
There was a problem hiding this comment.
I see you had a deprecation message in here before, why not show that for at least one release? The setting previously existed for 11 months
There was a problem hiding this comment.
from @rebornix's input, we can just remove it since it won't do anything and just mention it in the release notes.
joyceerhl
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the Interactive window is now built in through usage of the Working Copy Service so the setting no longer affects the behavior.