Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove setting with no effect #186187

Merged
merged 2 commits into from
Jun 26, 2023
Merged

remove setting with no effect #186187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa5c6e3
deprecate restore setting
amunger Jun 26, 2023
f907729
remove setting
amunger Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/vs/workbench/contrib/interactive/browser/interactive.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,11 +791,6 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis
type: 'boolean',
default: true,
markdownDescription: localize('interactiveWindow.alwaysScrollOnNewCell', "Automatically scroll the interactive window to show the output of the last statement executed. If this value is false, the window will only scroll if the last cell was already the one scrolled to.")
},
[InteractiveWindowSetting.interactiveWindowRestore]: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you had a deprecation message in here before, why not show that for at least one release? The setting previously existed for 11 months

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from @rebornix's input, we can just remove it since it won't do anything and just mention it in the release notes.

type: 'boolean',
default: false,
markdownDescription: localize('interactiveWindow.restore', "Controls whether the Interactive Window sessions/history should be restored across window reloads. Whether the state of controllers used in Interactive Windows is persisted across window reloads are controlled by extensions contributing controllers.")
}
}
});
3 changes: 1 addition & 2 deletions src/vs/workbench/contrib/interactive/browser/interactiveCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ import { RawContextKey } from 'vs/platform/contextkey/common/contextkey';
export const INTERACTIVE_INPUT_CURSOR_BOUNDARY = new RawContextKey<'none' | 'top' | 'bottom' | 'both'>('interactiveInputCursorAtBoundary', 'none');

export const InteractiveWindowSetting = {
interactiveWindowAlwaysScrollOnNewCell: 'interactiveWindow.alwaysScrollOnNewCell',
interactiveWindowRestore: 'interactiveWindow.restore'
interactiveWindowAlwaysScrollOnNewCell: 'interactiveWindow.alwaysScrollOnNewCell'
};