Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Editor - margin revert icon should not be rendered when documents are read-only #186331

Closed
lszomoru opened this issue Jun 27, 2023 · 1 comment · Fixed by #186344
Closed

Diff Editor - margin revert icon should not be rendered when documents are read-only #186331

lszomoru opened this issue Jun 27, 2023 · 1 comment · Fixed by #186344
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2023

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 27, 2023 •
edited

Testing #186213

Used GitLens to compare a file between two branches which opens a diff editor where both sides are read-only. the margin revert icon is rendered to revert the change but it is a no-op since the document is read-only. We should not be rendering these glyphs for read-only documents.

This scenario can also be reproduced easier with:

  1. Make a change to a a file, and stage the change
  2. Click on the resource to open the diff editor
  3. Margin revert icon is rendered but it's a no-op as both documents are read-only.
@hediet hediet added this to the June 2023 milestone Jun 27, 2023
@hediet hediet mentioned this issue Jun 27, 2023
Merged
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels Jun 27, 2023
hediet added a commit that referenced this issue Jun 27, 2023
@hediet
Fixes #186331 - Diff Editor - margin revert icon should not be render…
7aa4e3e 
…ed when documents are read-only
@hediet
Copy link
Member

hediet commented Jun 27, 2023

You can also use Bens command "Toggle active editor readonly in session" to verify the bugfix.

hediet added a commit that referenced this issue Jun 28, 2023
@hediet
Fixes #186331 - Diff Editor - margin revert icon should not be render…
91c3459 
…ed when documents are read-only (#186344)
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2023
@lszomoru lszomoru added the verified Verification succeeded label Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2023
3 participants
@hediet @lszomoru @VSCodeTriageBot