-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Cannot read properties of undefined (reading 'scope') when remove config from non-default profile #186488
Labels
bug
Issue identified by VS Code Team member as probable bug
config
VS Code configuration, set up issues
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Milestone
Comments
It would be great if we can have a summary of steps to reproduce |
@Cosifne can you provide steps please? Thank you |
My repro step:
|
sandy081
added
bug
Issue identified by VS Code Team member as probable bug
config
VS Code configuration, set up issues
and removed
info-needed
Issue requires more information from poster
labels
Jul 4, 2023
Merged
VSCodeTriageBot
added
unreleased
Patch has not yet been released in VS Code Insiders
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Jul 4, 2023
@Cosifne can you verify that this fix indeed fixes the problem you reported. Thank you! |
Verified it is solved in 1.81.0-insider |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
config
VS Code configuration, set up issues
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Issue filed by @Cosifne
Hi,
I would like to ask about a problem related to the usage of WorkspaceConfiguration.Update()
We received an issue dotnet/vscode-csharp#5714
This happens when the C# extension starts,
we are migrating some old configurations to its new name when using a non-default profile. (This doesn't repro when use default profile)
See the code here:
https://github.com/dotnet/vscode-csharp/blob/ea41fa6d43349a4bd1404f4d8e3d68ee77abea32/src/shared/MigrateOptions.ts#L55
I tested locally and verified the issue in feedback happens when executing
await workspaceConfig.update(fromOption, undefined, ConfigurationTarget.Global);
during the extension activation.What I did is created a non-default profile, and put one of our deprecated options in the global profile.
Then the error occurs when removing the old configuration see this
The old configuration is removed in this case.
Is this our misuse of the API or is this a bug in vscode?
The text was updated successfully, but these errors were encountered: