Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when next/previous ghost text suggestion is shown, we don't alert screen reader users #186675

Closed
meganrogge opened this issue Jun 29, 2023 · 0 comments 路 Fixed by #187710
Closed

when next/previous ghost text suggestion is shown, we don't alert screen reader users #186675

meganrogge opened this issue Jun 29, 2023 · 0 comments 路 Fixed by #187710
Assignees
@hediet
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2023

Comments

@meganrogge
Copy link
Contributor

  1. trigger an inline ghost text suggestion
  2. use Alt+[ or ] to get new suggestions
  3. 馃悰 not announced to screen reader users

cc @jooyoungseo
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) labels Jun 29, 2023
@meganrogge meganrogge added this to the July 2023 milestone Jun 29, 2023
@meganrogge meganrogge removed their assignment Jul 11, 2023
@hediet hediet mentioned this issue Jul 12, 2023
Merged
hediet added a commit that referenced this issue Jul 12, 2023
@hediet
Fixes #186675
22d4892
hediet added a commit that referenced this issue Jul 12, 2023
@hediet
Fixes #186675 (#187710)
1864dfd 
* Fixes #186675

* Don't show screen reader hover when the text is read automatically.
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 12, 2023
@bhavyaus bhavyaus added the verified Verification succeeded label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug ghost-text Issues related to ghost text (used for inline-completions and suggestion preview) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #186675 microsoft/vscode
4 participants
@hediet @bhavyaus @meganrogge @VSCodeTriageBot