Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Server not working for Typescript notebooks #186811

Closed
nthh opened this issue Jul 1, 2023 · 1 comment · Fixed by #188186
Closed

TS Server not working for Typescript notebooks #186811

nthh opened this issue Jul 1, 2023 · 1 comment · Fixed by #188186
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2023

Comments

@nthh
Copy link

nthh commented Jul 1, 2023 •
edited

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Latest
  • OS Version: Mac M1

Steps to Reproduce:

  1. Open a notebook and add a Typescript cell (e.g. test.ipynb)
  2. Import anything (e.g. import fs from 'fs')

See DonJayamanne/typescript-notebook#79 (comment)
@nthh nthh mentioned this issue Jul 1, 2023
Closed
@mjbvz mjbvz added this to the July 2023 milestone Jul 18, 2023
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jul 18, 2023
@mjbvz mjbvz mentioned this issue Jul 18, 2023
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 18, 2023
@mjbvz
Make getWorkspaceRootForResource work for notebook cells
8a08a4c 
Fixes microsoft#186811
mjbvz added a commit that referenced this issue Jul 18, 2023
@mjbvz
Make getWorkspaceRootForResource work for notebook cells (#188186)
e2720e7 
Fixes #186811
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2023
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Jul 26, 2023
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@nthh, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 862fa13 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2023
4 participants
@rzhao271 @mjbvz @nthh @VSCodeTriageBot