Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on reviveTerminalProcesses in remote #187075

Closed
Tyriar opened this issue Jul 5, 2023 · 3 comments · Fixed by #189683
Closed

Error on reviveTerminalProcesses in remote #187075

Tyriar opened this issue Jul 5, 2023 · 3 comments · Fixed by #189683
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone
August 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2023

Repro:

  1. Open OSS
  2. Open new test resolver window
  3. Close non-test resolver window
  4. Close all terminals
  5. Exit application
  6. Open OSS
  7. Open pty host log

I see an error being returned from reviveTerminalProcesses:

2023-07-05 11:32:09.225 [trace] [RPC Request] PtyService#reviveTerminalProcesses...
2023-07-05 11:32:09.226 [error] [RPC Response] PtyService#reviveTerminalProcesses Cannot read properties of undefined (reading 'cwd')
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Jul 5, 2023
@Tyriar Tyriar added this to the July 2023 milestone Jul 5, 2023
@Tyriar Tyriar self-assigned this Jul 5, 2023
Tyriar added a commit that referenced this issue Jul 5, 2023
@Tyriar
Fix error in remote reviveTerminalProcesses
5b7a62c 
Fixes #187075
@Tyriar Tyriar mentioned this issue Jul 5, 2023
Closed
@Tyriar Tyriar modified the milestones: July 2023, August 2023 Jul 24, 2023
Tyriar added a commit that referenced this issue Aug 4, 2023
@Tyriar
Fix passing of reviveTerminalProcesses args to remote
e089a44 
Fixes #187075
@Tyriar Tyriar mentioned this issue Aug 4, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 4, 2023
@aeschli aeschli added the verification-steps-needed Steps to verify are needed for verification label Aug 31, 2023
@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2023

How do I open the pty host log ?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 31, 2023

Output > Pty Host

@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label Aug 31, 2023
@aeschli aeschli added the verified Verification succeeded label Aug 31, 2023
@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2023

Thanks, I didn't see it as I didn't have a terminal open yet

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2023
3 participants
@Tyriar @aeschli @VSCodeTriageBot