Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused audio cues #187837

Closed
hediet opened this issue Jul 13, 2023 · 2 comments
Closed

Remove unused audio cues #187837

hediet opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@hediet
Copy link
Member

hediet commented Jul 13, 2023

These audio cues do not seem to be used:

public static readonly chatResponseReceived1 = AudioCue.register({
sound: Sound.chatResponseReceived1,
...this.chatResponseReceived
});
public static readonly chatResponseReceived2 = AudioCue.register({
sound: Sound.chatResponseReceived2,
...this.chatResponseReceived
});
public static readonly chatResponseReceived3 = AudioCue.register({
sound: Sound.chatResponseReceived3,
...this.chatResponseReceived
});
public static readonly chatResponseReceived4 = AudioCue.register({
sound: Sound.chatResponseReceived4,
...this.chatResponseReceived
});

They appear in Help: List Audio Cues and I'm sure the sound files blow up the installer size.

@meganrogge
Copy link
Contributor

these are used when this is invoked

public playRandomAudioCue(groupId: AudioCueGroupId, allowManyInParallel?: boolean): void {

hediet added a commit that referenced this issue Jul 14, 2023
@hediet
Copy link
Member Author

hediet commented Jul 14, 2023

Ahh, what threw me off are the 0 references:

Code_-_Insiders_2Bb0r7ckyS

I think we should allow audio cues to have random sounds, getting rid of the groupId.

hediet added a commit that referenced this issue Jul 18, 2023
* Adresses #187837

* Fixes failed test
@hediet hediet assigned hediet and unassigned meganrogge Jul 18, 2023
@hediet hediet added this to the July 2023 milestone Jul 18, 2023
@hediet hediet added the debt Code quality issues label Jul 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants