Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about sticky scroll to editor accessibility help menu #187859

Closed
meganrogge opened this issue Jul 13, 2023 · 3 comments · Fixed by #191324 or #193383
Closed

Add info about sticky scroll to editor accessibility help menu #187859

meganrogge opened this issue Jul 13, 2023 · 3 comments · Fixed by #191324 or #193383
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2023

Comments

@meganrogge
Copy link
Contributor

related to #186659
@meganrogge meganrogge self-assigned this Jul 13, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jul 13, 2023
@meganrogge meganrogge added this to the July 2023 milestone Jul 13, 2023
@meganrogge meganrogge modified the milestones: July 2023, August 2023 Jul 20, 2023
meganrogge added a commit that referenced this issue Aug 25, 2023
@meganrogge
fix #187859
44e9c6d
@meganrogge meganrogge mentioned this issue Aug 25, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 25, 2023
@meganrogge meganrogge added the verification-needed Verification of issue is requested label Aug 25, 2023
@meganrogge
Copy link
Contributor Author

To verify, focus an editor. Use alt+f1 to open the accessibility help dialog. Ensure that there's info about focusing sticky scroll. Set a keybinding for the command to focus sticky scroll. Open the help dialog again and ensure that is included in the dialog. Disable sticky scroll. Ensure that info is no longer in the dialog.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 28, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 29, 2023
@rzhao271
Copy link
Contributor

After I disable sticky scroll, the accessibility help dialog still mentions Focus Sticky Scroll.

@rzhao271 rzhao271 reopened this Aug 29, 2023
@rzhao271 rzhao271 added the verification-found Issue verification failed label Aug 29, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Aug 29, 2023
@meganrogge meganrogge removed the verification-found Issue verification failed label Aug 29, 2023
@meganrogge meganrogge removed the verified Verification succeeded label Aug 29, 2023
@meganrogge
Copy link
Contributor Author

@rzhao271 did you close and reopen the help dialog? that's what is required here

@meganrogge meganrogge reopened this Aug 29, 2023
meganrogge added a commit that referenced this issue Sep 18, 2023
@meganrogge
fix #187859
facfc86
@meganrogge meganrogge mentioned this issue Sep 18, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 18, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 19, 2023
@jrieken jrieken added the verified Verification succeeded label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2023
4 participants
@jrieken @rzhao271 @meganrogge @VSCodeTriageBot