-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook UI heading tweaks #188117
Notebook UI heading tweaks #188117
Conversation
@microsoft-github-policy-service agree company="Stateful Inc." |
Not sure if you saw this but I recently updated the markdown styles in VS Code itself in #185801. I think it would make more sense to align to those vs. an extension. |
@daviddossett thanks for the reply! I have not seen that commit but we almost made the same change. I pushed another commit to make it more align with your changes. Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi there 馃憢
I am Christian and part of the development team that has build a VS Code extension called Runme. It is an extension that renders markdown files as notebooks and allows them to execute/run the code snippets in their. Runme is currently featured on the VS Code Marketplace and grows fast day by day.
Some of the feedback we have received is that the markdown within notebooks doesn't render the same way markdown preview extension would render it. Here is example:
Markdown Example rendered in VS Code notebook view
Markdown Example rendered with Markdown Preview Enhanced
We have been looking at many markdown preview extensions and we see the UI diverging mostly in the following areas:
<hr />
element height is too big (2px vs. 1px)I am proposing some small tweaks to the
markdown-language-features
extension that adjusts the styles so that it comes marginally closer to how VS Code would render markdown usually.See a preview here:
It lowers the visual difference between viewing markdown within a markdown preview extension or within the notebook UI.
Happy to answer any questions.
Thanks for reviewing.