Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook UI heading tweaks #188117

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Notebook UI heading tweaks #188117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d84eb
Notebook UI heading tweaks
christian-bromann Jul 17, 2023
237a9b7
align styles
christian-bromann Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
65 changes: 44 additions & 21 deletions extensions/markdown-language-features/notebook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,42 +176,39 @@ export const activate: ActivationFunction<void> = (ctx) => {

hr {
border: 0;
height: 2px;
border-bottom: 2px solid;
}

h2, h3, h4, h5, h6 {
font-weight: normal;
height: 1px;
border-bottom: 1px solid;
}

h1 {
font-size: 2.3em;
font-size: 2em;
margin-top: 0;
padding-bottom: 0.3em;
border-bottom-width: 1px;
border-bottom-style: solid;
}

h2 {
font-size: 2em;
font-size: 1.5em;
padding-bottom: 0.3em;
border-bottom-width: 1px;
border-bottom-style: solid;
}

h3 {
font-size: 1.7em;
}

h3 {
font-size: 1.5em;
font-size: 1.25em;
}

h4 {
font-size: 1.3em;
font-size: 1em;
}

h5 {
font-size: 1.2em;
font-size: 0.875em;
}

h1,
h2,
h3 {
font-weight: normal;
h6 {
font-size: 0.85em;
}

div {
Expand All @@ -229,12 +226,38 @@ export const activate: ActivationFunction<void> = (ctx) => {
}

/* Removes bottom margin when only one item exists in markdown cell */
#preview > *:only-child,
#preview > *:last-child {
#preview > *:not(h1):not(h2):only-child,
#preview > *:not(h1):not(h2):last-child {
margin-bottom: 0;
padding-bottom: 0;
}

h1,
h2,
h3,
h4,
h5,
h6 {
font-weight: 600;
margin-top: 24px;
margin-bottom: 16px;
line-height: 1.25;
}

.vscode-light h1,
.vscode-light h2,
.vscode-light hr,
.vscode-light td {
border-color: rgba(0, 0, 0, 0.18);
}

.vscode-dark h1,
.vscode-dark h2,
.vscode-dark hr,
.vscode-dark td {
border-color: rgba(255, 255, 255, 0.18);
}

/* makes all markdown cells consistent */
div {
min-height: var(--notebook-markdown-min-height);
Expand Down
2 changes: 2 additions & 0 deletions src/vs/workbench/contrib/markdown/browser/markdownDocumentRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,14 @@ pre code {
}

.vscode-light h1,
.vscode-light h2,
.vscode-light hr,
.vscode-light td {
border-color: rgba(0, 0, 0, 0.18);
}

.vscode-dark h1,
.vscode-dark h2,
.vscode-dark hr,
.vscode-dark td {
border-color: rgba(255, 255, 255, 0.18);
Expand Down