Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile creation does not respect name #188138

Closed
isidorn opened this issue Jul 18, 2023 · 2 comments · Fixed by #188148
Closed

Profile creation does not respect name #188138

isidorn opened this issue Jul 18, 2023 · 2 comments · Fixed by #188148
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders user-profiles User profile management verified Verification succeeded
Milestone
July 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2023 •
edited

  1. Create profile flow.
  2. Choose copy from "Python" template
  3. Name your profile "My Profile"
  4. Get unexpected warning. It looks like "My Profile" name is not respected

Screenshot 2023-07-18 at 10 52 23
@isidorn isidorn added the user-profiles User profile management label Jul 18, 2023
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jul 18, 2023
@sandy081 sandy081 added this to the July 2023 milestone Jul 18, 2023
@sandy081 sandy081 mentioned this issue Jul 18, 2023
Merged
sandy081 added a commit that referenced this issue Jul 18, 2023
@sandy081
fix #188138
a242f80
sandy081 added a commit that referenced this issue Jul 18, 2023
@sandy081
fix #188138 (#188148)
2df2965
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 18, 2023
@IanMatthewHuff
Copy link
Member

@isidorn @sandy081 On the VSCode education team we had a profile called default.code-profile that we use for our default UI configuration. In that profile I recently changed the name to "education" in the name attribute inside the profile but was surprised that the name continued to be "Default" when we loaded our profile via the vscode.dev route option. When I changed the name I expected that to be used versus the file name (I didn't notice this before as both the file and the name attribute were previously "default").

Is that the same issue as this here? It looks similar, but looking at the PR above I wasn't totally sure.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 19, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jul 19, 2023

@IanMatthewHuff that sounds like another bug if I am not mistaken. I suggest to open a new issue. Thank you

@isidorn isidorn added the verified Verification succeeded label Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders user-profiles User profile management verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

fix #188138 microsoft/vscode
4 participants
@IanMatthewHuff @isidorn @sandy081 @VSCodeTriageBot