Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WelcomeUX] Overlay moved up in OSX insider #18854

Closed
chrmarti opened this issue Jan 20, 2017 · 1 comment
Closed

[WelcomeUX] Overlay moved up in OSX insider #18854

chrmarti opened this issue Jan 20, 2017 · 1 comment
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2017

Comments

@chrmarti
Copy link
Contributor

Testing #18091

My guess is that the custom title bar affects it. Placing it a little lower in the DOM might fix this.
@chrmarti chrmarti self-assigned this Jan 20, 2017
@chrmarti chrmarti mentioned this issue Jan 20, 2017
Closed
@chrmarti chrmarti added this to the January 2017 milestone Jan 21, 2017
@chrmarti
Copy link
Contributor Author

@bgashler1 I'm fixing this by making the overlay smaller if there is a custom titlebar, that's easiest for now. We could change that to instead move all affected arrows and labels down, such that, the titlebar is blurred by the overlay too.

chrmarti added a commit that referenced this issue Jan 21, 2017
@chrmarti
Shrink overlay with custom titlebar (fixes #18854)
b33b824
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2017
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
2 participants
@chrmarti @ramya-rao-a