Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot navigate to next diff in embedded diff editor #188934

Closed
hediet opened this issue Jul 26, 2023 · 1 comment · Fixed by #188941 or #189139
Closed

Cannot navigate to next diff in embedded diff editor #188934

hediet opened this issue Jul 26, 2023 · 1 comment · Fixed by #188941 or #189139
Assignees
@hediet
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verification-found Issue verification failed verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone
July 2023

Comments

@hediet
Copy link
Member

hediet commented Jul 26, 2023 •
edited

Testing #188537

Code_-_Insiders_nldJ3tQoQY

Verification steps:

  • Enable screenreader mode
  • Use Inline chat that generates a diff with 2 changed hunks that are at least 6 lines apart
  • Verify the accessible diff viewer is used to display the diff
  • Verify that you can use F7 to cycle through the hunks (this only works if you have more than 2 hunks!)
@hediet hediet added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues labels Jul 26, 2023
@hediet hediet added this to the July 2023 milestone Jul 26, 2023
@hediet hediet self-assigned this Jul 26, 2023
@hediet hediet mentioned this issue Jul 26, 2023
Merged
hediet added a commit that referenced this issue Jul 26, 2023
@hediet
Fixes #188934
a827ef3
hediet added a commit that referenced this issue Jul 26, 2023
@hediet
Fixes #188934 (#188941)
525f0a6
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 26, 2023
@andreamah andreamah added the verification-steps-needed Steps to verify are needed for verification label Jul 27, 2023
@meganrogge
Copy link
Contributor

I no longer see Go to next difference in the command palette. I also tried assigning a keybinding to editor.action.diffReview.next and that did not work.

Screen.Recording.2023-07-27.at.2.04.00.PM.mov

@meganrogge meganrogge reopened this Jul 27, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jul 27, 2023
@andreamah andreamah added the verification-found Issue verification failed label Jul 27, 2023
@hediet hediet added the candidate Issue identified as probable candidate for fixing in the next release label Jul 28, 2023
@hediet hediet mentioned this issue Jul 28, 2023
Merged
hediet added a commit that referenced this issue Jul 28, 2023
@hediet
Fixes #188934
fabaee7
hediet added a commit that referenced this issue Jul 28, 2023
@hediet
Fixes #188934 (#189139)
b3ebdfa
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 28, 2023
hediet added a commit that referenced this issue Jul 28, 2023
@hediet
Fixes #188934 (#189139)
1e29a2d
@hediet hediet mentioned this issue Jul 28, 2023
Merged
hediet added a commit that referenced this issue Jul 28, 2023
@hediet
Merge pull request #189150 from microsoft/hediet/release-fix2
9800cf6 
Fixes #188934 in release
@isidorn isidorn added the verified Verification succeeded label Aug 2, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verification-found Issue verification failed verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Fixes #188934 microsoft/vscode
Fixes #188934 microsoft/vscode
5 participants
@isidorn @hediet @meganrogge @andreamah @VSCodeTriageBot