Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerline symbols should not be included in links #189222

Closed
Tyriar opened this issue Jul 29, 2023 · 0 comments · Fixed by #189223
Closed

Powerline symbols should not be included in links #189222

Tyriar opened this issue Jul 29, 2023 · 0 comments · Fixed by #189223
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone
August 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 29, 2023

When using a powerline prompt:

image

We should not be allowing the powerline symbols to be links (ctrl+hover):

image

Running the open detected links command is the clearest way to see this:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-links labels Jul 29, 2023
@Tyriar Tyriar added this to the August 2023 milestone Jul 29, 2023
@Tyriar Tyriar self-assigned this Jul 29, 2023
Tyriar added a commit that referenced this issue Jul 29, 2023
@Tyriar
Ignore powerline symbols in word links
4223793 
Fixes #189222
@Tyriar Tyriar mentioned this issue Jul 29, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Ignore powerline symbols in word links microsoft/vscode
3 participants
@Tyriar @joyceerhl @VSCodeTriageBot