Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WelcomeUX] Pressing F8 to jump to next error in embedded editor loses place in walkthrough #18929

Closed
mousetraps opened this issue Jan 20, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone

Comments

@mousetraps
Copy link
Contributor

Testing #18091

@chrmarti chrmarti added this to the January 2017 milestone Jan 25, 2017
@chrmarti
Copy link
Contributor

This happens when MarkerNavigationWidget calls focus() on the container. Commenting that makes the viewport not jump anymore. Tried for some time to understand what is going on without luck. @jrieken Any hints you can give on that? I see the zone widget being offscreen, but that seems to be the same in the regular editor.

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jan 26, 2017
@jrieken
Copy link
Member

jrieken commented Jan 26, 2017

Not really sure what you mean.

@jrieken
Copy link
Member

jrieken commented Jan 26, 2017

Ok, now i have seen it. According to @alexandrudima this happens because we call focus and because then the browser wants to really, really make sure the element is in the viewport. Unsure what to do next. We call focus because of accessibility but we can also thing about having a second set of command that only reveal and don't focus

@alexdima
Copy link
Member

Well, that is what I speculate happens. But it needs to be confirmed by looking if the scrollTop changes.

@chrmarti
Copy link
Contributor

scrollTop of the div that is used for scrolling by the DOMScrollableElement does indeed change. Removing the .focus() call stops the scrolling. What I don't quite understand yet is why we don't see the same happening with the regular editor, does that use a different approach for scrolling?

@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Jan 26, 2017
@bpasero bpasero added the verified Verification succeeded label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants