You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mousetraps opened this issue
Jan 20, 2017
· 5 comments
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseverifiedVerification succeeded
This happens when MarkerNavigationWidget calls focus() on the container. Commenting that makes the viewport not jump anymore. Tried for some time to understand what is going on without luck. @jrieken Any hints you can give on that? I see the zone widget being offscreen, but that seems to be the same in the regular editor.
Ok, now i have seen it. According to @alexandrudima this happens because we call focus and because then the browser wants to really, really make sure the element is in the viewport. Unsure what to do next. We call focus because of accessibility but we can also thing about having a second set of command that only reveal and don't focus
scrollTop of the div that is used for scrolling by the DOMScrollableElement does indeed change. Removing the .focus() call stops the scrolling. What I don't quite understand yet is why we don't see the same happening with the regular editor, does that use a different approach for scrolling?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseverifiedVerification succeeded
Testing #18091
The text was updated successfully, but these errors were encountered: