fix nb-sticky css #189350
Merged
fix nb-sticky css #189350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jul 31, 2023
|
|
||
| .monaco-workbench.hc-light .notebookOverlay .notebook-sticky-scroll-container, | ||
| .monaco-workbench.hc-black .notebookOverlay .notebook-sticky-scroll-container { | ||
| background-color: var(--vscode-editorStickyScroll-background); |
There was a problem hiding this comment.
Why are these rules different for hc themes?
There was a problem hiding this comment.
It addresses the borders that specifically the high contrast themes use. I couldn't hunt down a background-color from within notebook css that didn't show overlapping text. Issue is only for the hc-themes, not sure what css rule is causing this.
Editor sticky scroll has the same fix for this, manually adding the border. It just doesn't need to alter the background-color.
|
screenshot of fix: Upper left -- current insiders |
rzhao271
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #189195
fixes styling for
hc-lightandhc-blackthemes in vscode. Adds background color and bottom border to sticky-container.