Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nb-sticky css #189350

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix nb-sticky css #189350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42dceee
fix nb-sticky css
Yoyokrazy Jul 31, 2023
f67b7bd
Merge branch 'release/1.81' into sticky-candidate-fix
Yoyokrazy Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/vs/workbench/contrib/notebook/browser/media/notebookEditorStickyScroll.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
width: 100%;
font-family: var(--notebook-cell-input-preview-font-family);
}

.monaco-workbench.hc-light .notebookOverlay .notebook-sticky-scroll-container,
.monaco-workbench.hc-black .notebookOverlay .notebook-sticky-scroll-container {
background-color: var(--vscode-editorStickyScroll-background);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these rules different for hc themes?

Copy link
Contributor Author

@Yoyokrazy Yoyokrazy Jul 31, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It addresses the borders that specifically the high contrast themes use. I couldn't hunt down a background-color from within notebook css that didn't show overlapping text. Issue is only for the hc-themes, not sure what css rule is causing this.

Editor sticky scroll has the same fix for this, manually adding the border. It just doesn't need to alter the background-color.

border-bottom: 1px solid var(--vscode-contrastBorder);
}

.monaco-workbench
.notebookOverlay
.notebook-sticky-scroll-container
Expand Down