Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WelcomeUX] Editor Theme, also tell me how do get there myself? #18938

Closed
ramya-rao-a opened this issue Jan 20, 2017 · 5 comments
Closed

[WelcomeUX] Editor Theme, also tell me how do get there myself? #18938

ramya-rao-a opened this issue Jan 20, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 20, 2017

Testing #18091 on OS X El Capitan

Clicking on "Editor theme" quick link opens the command pallet for user to change the theme.
But, this doesn't help the user learn how to do it the next time.

May be include the command (Preferences: Color Theme) in the text or the menu route
Code -> Preferences -> Color Theme.

Same thing for "Show All Commands". We can include the keyboard shortcut there.
And for "Change Settings"

@seanmcbreen
Copy link

I agree this would be good to do (we just added all the shortcuts to the overlay) but I don't think we can do it cleanly in the design currently. So we may have to wait for the next update.

@chrmarti
Copy link
Contributor

It's most important for Show All Commands, that is not usable (in any reasonable way) without the shortcut.

@chrmarti chrmarti added this to the January 2017 milestone Jan 21, 2017
@chrmarti
Copy link
Contributor

@bgashler1 We can add shortcuts using, e.g., <span class="shortcut" data-command="workbench.action.showCommands"></span>. These will need some styling. Could you consider that for the January release?

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2017
@chrmarti
Copy link
Contributor

Adding it to Show All Commands for now.

@chrmarti
Copy link
Contributor

Verifier: Please check Windows and Linux.

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Jan 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants