Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Accessible Diff Viewer command always displayed in an open editor #189444

Closed
gregvanl opened this issue Aug 2, 2023 · 2 comments
Closed

Open Accessible Diff Viewer command always displayed in an open editor #189444

gregvanl opened this issue Aug 2, 2023 · 2 comments
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor mode issues verified Verification succeeded
Milestone
July 2023

Comments

@gregvanl
Copy link

gregvanl commented Aug 2, 2023

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Open a Markdown file without pending changes and check the More Actions menu in the upper right of the editor.

The Open Accessible Diff Viewer command is visible. Selecting the command has no effect.

image

  1. Open the Markdown preview for the file and check the More Actions menu.

The Open Accessible Diff Viewer command is visible.

image
@hediet hediet added candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor mode issues labels Aug 2, 2023
@hediet hediet added this to the July 2023 milestone Aug 2, 2023
@hediet hediet mentioned this issue Aug 2, 2023
Merged
hediet added a commit that referenced this issue Aug 2, 2023
@hediet
Fixes #189444 in release
7b86cdf
@hediet
Copy link
Member

hediet commented Aug 2, 2023

Thanks for finding this! I don't know how I missed this.

@hediet hediet mentioned this issue Aug 2, 2023
Merged
hediet added a commit that referenced this issue Aug 2, 2023
@hediet
Adresses #189444
7711994
hediet added a commit that referenced this issue Aug 2, 2023
@hediet
Adresses #189444
f448922
hediet added a commit that referenced this issue Aug 2, 2023
@hediet
Fixes #189444 in release
20150e1
hediet added a commit that referenced this issue Aug 2, 2023
@hediet
Merge pull request #189459 from microsoft/hediet/b/worried-ape
6445d93 
Fixes #189444 in release
@hediet
Copy link
Member

hediet commented Aug 2, 2023

Fixed by #189459 and #189460

@hediet hediet closed this as completed Aug 2, 2023
@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label Aug 2, 2023
@isidorn isidorn added the verified Verification succeeded label Aug 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor mode issues verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

No branches or pull requests
3 participants
@isidorn @hediet @gregvanl